Discussion:
subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273L bad if ?
David Binderman
2018-07-22 10:18:53 UTC
Permalink
Hello there,


subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273]: (style) Expression is always false because 'else if' condition matches previous condition at line 271.

Source code is


else if (strcmp(name, "DAV:" SVN_DAV__VERSION_NAME) == 0)
lrb.dirent_fields |= SVN_DIRENT_CREATED_REV;
else if (strcmp(name, "DAV:" SVN_DAV__CREATIONDATE) == 0)
lrb.dirent_fields |= SVN_DIRENT_TIME;


Regards


David Binderman
Daniel Shahaf
2018-07-22 17:07:38 UTC
Permalink
Post by David Binderman
subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273]: (style)
Expression is always false because 'else if' condition matches previous
condition at line 271.
(I replied on https://issues.apache.org/jira/browse/SVN-4765. David,
for future reference, we prefer emails to tickets. Thanks again for
the report.)

Loading...